Simplify log statements.

Make use of format specifiers in the logging library rather than relying on
string.format(), which makes log output unnecessarily verbose.
This commit is contained in:
Peter Gardfjäll
2020-04-07 12:49:44 +02:00
parent 4ee0cda314
commit c00ccd3887
7 changed files with 38 additions and 38 deletions
+8 -8
View File
@@ -11,7 +11,7 @@ logging.basicConfig(level=logging.INFO, format="%(asctime)-15s [%(levelname)s] %
log = logging.getLogger(__name__)
if __name__ == "__main__":
parser = argparse.ArgumentParser(
description="Export all Garmin Connect activities")
# positional args
@@ -26,22 +26,22 @@ if __name__ == "__main__":
if not args.password:
args.password = getpass.getpass("Enter password: ")
try:
with GarminClient(args.username, args.password) as client:
log.info("activities:")
activity_ids = client.list_activities()
log.info("num ids: {}".format(len(activity_ids)))
log.info("num ids: %d", len(activity_ids))
log.info(activity_ids)
latest_activity, latest_activity_start = activity_ids[0]
activity = client.get_activity_summary(latest_activity)
log.info("activity id: {}".format(activity["activity"]["activityId"]))
log.info("activity name: '{}'".format(activity["activity"]["activityName"]))
log.info("activity description: '{}'".format(activity["activity"]["activityDescription"]))
log.info("activity id: %s", activity["activity"]["activityId"])
log.info("activity name: '%s'", activity["activity"]["activityName"])
log.info("activity description: '%s'", activity["activity"]["activityDescription"])
log.info(json.dumps(client.get_activity_details(latest_activity), indent=4))
log.info(client.get_activity_gpx(latest_activity))
except Exception as e:
log.error("failed with exception: {}".format(e))
finally:
log.error("failed with exception: %s", e)
finally:
log.info("done")